Support showing NSX LB SNAT IP in networkinfo CR #1018

timdengyun · 2025-01-27T18:38:43Z

Getting VPC policy Tier1 uplink port IP as NSX LB SNAT IP in order to present it in networkinfo CR loadBalancerIPAddresses field.

Test done:
NSX API output for vpc-vw8t for VPC T1 uplink and downlink Port info

GET https://10.192.27.76/policy/api/v1/infra/realized-state/realized-entities?intent_path=/orgs/default/projects/a9425f85-3da3-462d-9957-c44d729d7e63/vpcs/vpc-vw8t
{
            "extended_attributes": [
                {
                    "data_type": "STRING",
                    "multivalue": true,
                    "values": [
                        "100.64.0.2/31"
                    ],
                    "key": "IpAddresses"
                },
                {
                    "data_type": "STRING",
                    "multivalue": false,
                    "values": [
                        "02:50:56:56:44:52"
                    ],
                    "key": "MacAddress"
                }
            ],
            "entity_type": "RealizedLogicalRouterPort",
            "intent_paths": [
                "/orgs/default/projects/a9425f85-3da3-462d-9957-c44d729d7e63/vpcs/vpc-vw8t",
                "/orgs/default/projects/a9425f85-3da3-462d-9957-c44d729d7e63/transit-gateways/default"
            ],
            "resource_type": "GenericPolicyRealizedResource",
            "id": "vpc-vw8t",
            "display_name": "default-vpc-vw8t-t0_lrp",
            "path": "/orgs/default/projects/a9425f85-3da3-462d-9957-c44d729d7e63/realized-state/enforcement-points/default/transit-gateways/default/vpc-interfaces/vpc-vw8t",
            "relative_path": "vpc-vw8t",
           ..
        },
{
            "extended_attributes": [
                {
                    "data_type": "STRING",
                    "multivalue": true,
                    "values": [
                        "100.64.0.3/31"
                    ],
                    "key": "IpAddresses"
                },
                {
                    "data_type": "STRING",
                    "multivalue": false,
                    "values": [
                        "02:50:56:56:44:55"
                    ],
                    "key": "MacAddress"
                }
            ],
            "entity_type": "RealizedLogicalRouterPort",
            "intent_paths": [
                "/orgs/default/projects/a9425f85-3da3-462d-9957-c44d729d7e63/vpcs/vpc-vw8t"
            ],
            "resource_type": "GenericPolicyRealizedResource",
            "id": "gateway-interface",
            "display_name": "default-vpc-vw8t-t1_lrp",
            "path": "/orgs/default/projects/a9425f85-3da3-462d-9957-c44d729d7e63/realized-state/enforcement-points/default/vpcs/vpc-vw8t/gateway-interface",
            "relative_path": "gateway-interface",
                 ..
        },

This PR is to show 100.64.0.3 as loadBalancerIPAddresses SNAT IP for namespace: ns-1 which is associated with VPC vpc-vw8t

kubectl get networkinfo ns-1 -nns-1 -o yaml
apiVersion: crd.nsx.vmware.com/v1alpha1
kind: NetworkInfo
metadata:
  creationTimestamp: "2025-01-21T17:16:23Z"
  generation: 3
  name: ns-1
  namespace: ns-1
  resourceVersion: "5848475"
  uid: 6bb633fc-08c8-4f95-9ca2-829033b6c2b2
vpcs:
- defaultSNATIP: 10.1.0.1
  loadBalancerIPAddresses: 100.64.0.3
  name: vpc-vw8t
  privateIPs:
  - 192.168.0.0/16

codecov-commenter · 2025-01-27T18:46:34Z

Codecov Report

Attention: Patch coverage is 87.27273% with 7 lines in your changes missing coverage. Please review.

Project coverage is 74.30%. Comparing base (6c54354) to head (bbb2e85).

Files with missing lines	Patch %	Lines
.../controllers/networkinfo/networkinfo_controller.go	81.81%	4 Missing ⚠️
pkg/nsx/services/vpc/vpc.go	76.92%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
+ Coverage   74.24%   74.30%   +0.05%     
==========================================
  Files         118      118              
  Lines       16398    16445      +47     
==========================================
+ Hits        12175    12219      +44     
- Misses       3453     3455       +2     
- Partials      770      771       +1

Flag	Coverage Δ
unit-tests	`74.30% <87.27%> (+0.05%)`	⬆️

Files with missing lines	Coverage Δ
pkg/nsx/services/realizestate/realize_state.go	`100.00% <100.00%> (ø)`
pkg/nsx/services/vpc/vpc.go	`55.37% <76.92%> (+0.28%)`	⬆️
.../controllers/networkinfo/networkinfo_controller.go	`69.05% <81.81%> (+0.94%)`	⬆️

Getting VPC Ppolicy Tier1 uplink port IP as NSX LB SNAT IP in order to present it in networkinfo CR loadBalancerIPAddresses field.

lxiaopei · 2025-02-05T07:46:42Z

pkg/nsx/services/vpc/vpc.go

@@ -679,6 +678,22 @@ func (s *VPCService) GetAVISubnetInfo(vpc model.Vpc) (string, string, error) {
 	return path, cidr, nil
 }

+func (s *VPCService) GetNSXLBSNATIP(vpc model.Vpc) (string, error) {
+	log.V(2).Info("Get VPC NSX LB SNAT IP", "VPC", *vpc.Id)


Get -> Getting? seem the convention uses "Getting" before operation and "Got" after operation finished.

TaoZou1

In
Getting VPC Ppolicy -> policy

TaoZou1 · 2025-02-05T07:46:56Z

pkg/nsx/services/realizestate/realize_state.go

+		for i := range extendAttributes {
+			if extendAttributes[i].Key != nil && *extendAttributes[i].Key == "IpAddresses" {
+				if len(result.IntentPaths) == 1 {
+					for _, ip := range extendAttributes[i].Values {


could you move
if len(result.IntentPaths) == 1 before Line 91?
if if len(result.IntentPaths) != 1 {
continue
}

If extendAttributes[i].Values has multiple values, it seems you will use the first legal one.
is it possible to have multiple legal value?

TaoZou1 · 2025-02-05T07:47:47Z

pkg/nsx/services/realizestate/realize_state.go

+					for _, ip := range extendAttributes[i].Values {
+						parts := strings.Split(ip, "/")
+						if len(parts) != 2 {
+							log.Info("Invalid tier1 uplink port IP found", "IP", ip, "Path", intentPath)


lxiaopei · 2025-02-05T07:59:23Z

pkg/nsx/services/realizestate/realize_state.go

+		return "", err
+	}
+
+	for _, result := range results.Results {


could we filter by entity_type=RealizedLogicalRouterPort?

lxiaopei · 2025-02-05T08:04:42Z

pkg/controllers/networkinfo/networkinfo_controller.go

 			setNSNetworkReadyCondition(ctx, r.Client, req.Namespace, nsMsgVPCAviSubnetError.getNSNetworkCondition(err))
 			return common.ResultRequeueAfter10sec, err
 		}
+		lbIP = aviSECIDR
+	} else if lbProvider == vpc.NSXLB {
+		nsxLBSNATIP, err = r.Service.GetNSXLBSNATIP(*createdVpc)


could we return the VPC Tier1 LB SNAT IP in CreateOrUpdateVPC func when checking the realization state of VPC?
we can avoid a new NSX API call to get VPC realization state again.

could you also help check if VPC is created with AVI Subnet, we still can get the LB SNAT IP right?

Support showing NSX LB SNAT IP in networkinfo CR

bbb2e85

Getting VPC Ppolicy Tier1 uplink port IP as NSX LB SNAT IP in order to present it in networkinfo CR loadBalancerIPAddresses field.

timdengyun force-pushed the add_get_nsxlb_snatip branch from ba3170b to bbb2e85 Compare January 27, 2025 18:59

timdengyun requested review from TaoZou1 and lxiaopei February 2, 2025 03:15

timdengyun mentioned this pull request Feb 5, 2025

Refine NetworkInfo CR VPCState.LoadBalancerIPAddresses description #1005

Closed

lxiaopei reviewed Feb 5, 2025

View reviewed changes

TaoZou1 reviewed Feb 5, 2025

View reviewed changes

lxiaopei reviewed Feb 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support showing NSX LB SNAT IP in networkinfo CR #1018

Support showing NSX LB SNAT IP in networkinfo CR #1018

timdengyun commented Jan 27, 2025 •

edited by TaoZou1

Loading

codecov-commenter commented Jan 27, 2025 •

edited

Loading

lxiaopei Feb 5, 2025

TaoZou1 left a comment

TaoZou1 Feb 5, 2025

TaoZou1 Feb 5, 2025

TaoZou1 Feb 5, 2025

lxiaopei Feb 5, 2025

lxiaopei Feb 5, 2025

lxiaopei Feb 5, 2025

Support showing NSX LB SNAT IP in networkinfo CR #1018

Are you sure you want to change the base?

Support showing NSX LB SNAT IP in networkinfo CR #1018

Conversation

timdengyun commented Jan 27, 2025 • edited by TaoZou1 Loading

codecov-commenter commented Jan 27, 2025 • edited Loading

Codecov Report

lxiaopei Feb 5, 2025

Choose a reason for hiding this comment

TaoZou1 left a comment

Choose a reason for hiding this comment

TaoZou1 Feb 5, 2025

Choose a reason for hiding this comment

TaoZou1 Feb 5, 2025

Choose a reason for hiding this comment

TaoZou1 Feb 5, 2025

Choose a reason for hiding this comment

lxiaopei Feb 5, 2025

Choose a reason for hiding this comment

lxiaopei Feb 5, 2025

Choose a reason for hiding this comment

lxiaopei Feb 5, 2025

Choose a reason for hiding this comment

timdengyun commented Jan 27, 2025 •

edited by TaoZou1

Loading

codecov-commenter commented Jan 27, 2025 •

edited

Loading